Can only agree with what has been so said so far.
I do not play this faction myself - just having played against them and read/listend up to a lot of discussions - so take the following with a grain of salt
Osgiliath Veterans are in general shunned because for a few points more, you get warriors (Citadel Guard, Fountain Guard) with better profiles and rule. So unless you plan on a thematic Osgiliath list, you can leave them out.
Don't know what your opinion on warmaschines is but I definitely would go for an Avenger Bolt-Thrower - it sounds like a lot of fun and gives you area control
Knights of Minas Tirith are a good cavalry option and can provide you with speed.
Herowise it depends on where you wanna go - with the Denethor pack you have a good start. You can add more smaller heroes and most of them are good.
For more points most people go either for Boromir or Gandalf the White or Aragorn King Elessar.
Rangers as support with spears and bows behind your warriors are also good.